Fix feed URL (duplicated http://)#257
Merged
rochacbruno merged 1 commit intorochacbruno:mainfrom Apr 14, 2025
cuducos:fix-feed-url
Merged
Fix feed URL (duplicated http://)#257rochacbruno merged 1 commit intorochacbruno:mainfrom cuducos:fix-feed-url
http://)#257rochacbruno merged 1 commit intorochacbruno:mainfrom
cuducos:fix-feed-url
Conversation
rochacbruno
approved these changes
Apr 14, 2025
osantana
reviewed
Apr 14, 2025
|
|
||
| let feed_url = if !config.url.contains("http://") || !config.url.contains("https://") { | ||
| let feed_url = if !config.url.starts_with("http://") && !config.url.starts_with("https://") { | ||
| format!("http://{}", &config.url) |
There was a problem hiding this comment.
should we use https:// instead of http:// or choose one of them based on a configuration?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic used to say if the string does not contain
https://orhttps://— it should be and instead because full URLs would have one or the other ; )(Plus minor change to use
.starts_withinstead of justcontains)