Skip to content

feat: Add enable_related_content flag#221

Merged
rochacbruno merged 2 commits intorochacbruno:mainfrom
cauabernardino:feature/allow-disabling-related-content
Feb 3, 2025
Merged

feat: Add enable_related_content flag#221
rochacbruno merged 2 commits intorochacbruno:mainfrom
cauabernardino:feature/allow-disabling-related-content

Conversation

@cauabernardino
Copy link
Copy Markdown
Contributor

@cauabernardino cauabernardino commented Feb 2, 2025

Add new flag to enable/disable related content and back links for a post.
Defaults to true.

For issue #192

 - Flag will enable/disable related content and backlinks for a post
 - Defaults to false
@rochacbruno
Copy link
Copy Markdown
Owner

rochacbruno commented Feb 3, 2025

If we default it to false, it would be a breaking change, can we add it and default to True?

So it keeps current functionality and is easy to disable

@cauabernardino
Copy link
Copy Markdown
Contributor Author

Sure, makes sense!

I can update it tonight, if that's okay.

@cauabernardino
Copy link
Copy Markdown
Contributor Author

cauabernardino commented Feb 3, 2025

@rochacbruno done!

As the cli args are overwritten after the config file is parsed, I had to set the default value to None (to be skipped in override_from_cli_args) and let the serde resolve the default in Marmite

@rochacbruno rochacbruno merged commit 5ad2098 into rochacbruno:main Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants