Skip to content

Slack channel IDs stopped working #460

@StFS

Description

@StFS

Describe the bug
We used Slack channel IDs to specify the --slackoutput parameter. Recently that stopped working due to this change.

It appends a '#' in front of the value of --slackoutput if it isn't there already. However, this makes it impossible to provide a Slack channel ID rather than a slack channel name. This is inconvenient because if a channel is renamed krr scripts need to be updated, possibly in multiple places. Furthermore, with this change, there is no way to provide a slack channel ID rather than a slack channel name.

To Reproduce
Steps to reproduce the behavior:

  1. Run krr using --slackoutput "SLACKCHANNELID"

Expected behavior
The krr report should be sent to the slack channel that has that ID. Instead, an error message appears:

The server responded with: {'ok': False, 'error': 'channel_not_found'}

Are you interested in contributing a fix for this?
Yes - already submitted:
#461

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions