Control the included quota and storage providers via Go build tags#5
Closed
robstradling wants to merge 1 commit intopostgresql_supportfrom
Closed
Control the included quota and storage providers via Go build tags#5robstradling wants to merge 1 commit intopostgresql_supportfrom
robstradling wants to merge 1 commit intopostgresql_supportfrom
Conversation
2 tasks
|
I dig this. My only hesitation is that the build rules needing to list all other provider targets is somewhat brittle. But for how often we add new storage providers, we can probably live with it. Want to raise this as a draft PR against the repo and assign Al Cutter? |
Owner
Author
Yeah, I agree it's not ideal. The alternative was to break backcompat though, which I figured was a non-starter.
I'll make a note to do this after google#3644 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
google#3644 (comment) notes that the log-signer and log-server binaries are huge, due in part to the presence of multiple quota and storage providers. This PR enables providers to be included selectively via Go build tags.
By default and for backwards compatibility, all providers are included:
Specify one build tag to include just one provider:
Specify multiple, comma-separated build tags to include multiple providers. e.g.,: