add notToBeGreaterThan and notToBeLessThan #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreover: - make the distiction between toEqual and toBeEqualComparingTo clearer - rewrite ComparableExpectationsSpec to new nameing and include test cases for toBeLessThanOrEqualTo and toBeGreaterThanOrEqualTo where the equals/compareTo contract is broken
0703df5 to
44cd5e0
Compare
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
==========================================
+ Coverage 90.80% 90.82% +0.01%
==========================================
Files 407 407
Lines 4046 4054 +8
Branches 211 211
==========================================
+ Hits 3674 3682 +8
Misses 322 322
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moreover:
cases for toBeLessThanOrEqualTo and toBeGreaterThanOrEqualTo where
the equals/compareTo contract is broken
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.