Remove deprecated stuff #858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we cannot yet remove it because we still have addAssertion on Expect and if we remove it, would also have one on AssertionContainer. Two different definitions which would not work together. This also means: - deprecate addAssertion/addAssertionsCreatedBy/createAndAddAssertion in Expect, add append... to AssertionContainer
We don't apply the fix if only for the last target in case we already have the sources of this target but want to apply the fix to another.
RealTranslatorIntSpec was renamed to TranslatorIntSpec in a previous commit
same same for related function/types
Codecov Report
@@ Coverage Diff @@
## master #858 +/- ##
==========================================
+ Coverage 89.77% 90.41% +0.64%
==========================================
Files 407 402 -5
Lines 4040 3997 -43
Branches 211 211
==========================================
- Hits 3627 3614 -13
+ Misses 362 332 -30
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.