Skip to content

Issue/1555 map entry samples #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robstoll merged 3 commits into from
Oct 14, 2023
Merged

Issue/1555 map entry samples #1565

robstoll merged 3 commits into from
Oct 14, 2023

Conversation

@danherrera
Copy link
Contributor

@danherrera danherrera commented Oct 14, 2023

Issue #1555

api-fluent

  • add a entry method in MapLikeToContainInAnyOrderCreatorSamples for Map.toContain.inAnyOrder.only.entry(...)
  • add a entry method in MapLikeToContainInAnyOrderOnlyCreatorSamples for Map.toContain.inAnyOrder.entry(...)
  • add a entry method in MapLikeToContainInOrderOnlyCreatorSamples for Map.toContain.inOrder.only.entry(...)
  • add a entryKeyValue method in MapLikeToContainInAnyOrderCreatorSamples for Map.toContain.inAnyOrder.only.entry(KeyValue(...){ ... })
  • add a entryKeyValue method in MapLikeToContainInAnyOrderOnlyCreatorSamples for Map.toContain.inAnyOrder.entry(KeyValue(...){ ... })
  • add a entryKeyValue method in MapLikeToContainInOrderOnlyCreatorSamples for Map.toContain.inOrder.only.entry(KeyValue(...){ ... })
  • link in the KDoc of the corresponding function in mapLikeToContain...Creators.kt to the samples via @sample (see charSequenceToContainCreators.kt)

I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

@danherrera danherrera requested a review from robstoll as a code owner October 14, 2023 04:57
@codecov
Copy link

codecov bot commented Oct 14, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (58b4619) 90.60% compared to head (7ed09b3) 91.91%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1565      +/-   ##
============================================
+ Coverage     90.60%   91.91%   +1.30%     
  Complexity      114      114              
============================================
  Files           424      424              
  Lines          4600     4600              
  Branches        228      228              
============================================
+ Hits           4168     4228      +60     
+ Misses          384      326      -58     
+ Partials         48       46       -2
Flag Coverage Δ
current 91.47% <ø> (?)
current_windows 90.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...fluent/en_GB/mapLikeToContainInAnyOrderCreators.kt 100.00% <ø> (ø)
...nt/en_GB/mapLikeToContainInAnyOrderOnlyCreators.kt 100.00% <ø> (ø)
...luent/en_GB/mapLikeToContainInOrderOnlyCreators.kt 72.72% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robstoll robstoll linked an issue Oct 14, 2023 that may be closed by this pull request
samples for Map.toContain....entry #1555
Closed
7 tasks
@danherrera danherrera force-pushed the issue/1555-map-entry-samples branch from 943b48e to 0928988 Compare October 14, 2023 15:23
@danherrera danherrera mentioned this pull request Oct 14, 2023
Merged
robstoll
robstoll approved these changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@robstoll robstoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement

@robstoll robstoll merged commit a668d79 into robstoll:main Oct 14, 2023
@robstoll
Copy link
Owner

robstoll commented Oct 14, 2023

@danherrera thanks for your third contribution to Atrium, hat trick 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robstoll robstoll robstoll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

samples for Map.toContain....entry

2 participants

@danherrera @robstoll