Skip to content

Conversation

@robstoll
Copy link
Owner

based on #1418, thanks @vlsi

There are still a few things open (search for TODO 1.1.0 in /gradle dir) but I think it is good to merge and we can fix them afterwards


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

vlsi and others added 20 commits June 14, 2023 23:08
----
Slight adoption by robstoll:
- still let AbstractKotlinCompile depend on task and not KotlinCompile
  as this was not good enough in the past (still resulted in warnings)
moreover:
- deactivate build-logic.publish-to-tmp-maven-repo and leave TODO
  for later
moreover:
- don't repeat plugins, treat it more like a tree without duplicates
- add slowTest/SuiteLogThreshold so that
  com.github.vlsi.gradle-extensions does not print all tests
- move dokka configure into re-usable extension function
- disable localRepoElements.outgoing as it causes that the build task
  suddenly depend on the publish task
- make sure DokkaMultiModuleTask executes cleanDokkaHtmlPartial of specs
  and verbs-internal project as we don't want it
- move dokka configuration to root-build convention plugin
and turn it into a single module
moreover:
- remove println debug statements
- remove unused dependency gradle-plugin in publishing
- move includeBuild for build-logic plugins into pluginManagement block
this way we also get rid of the UNUSED_VARIABLE warnings
most contributors won't have to do anything in those files
hence they should not be that prominently placed in the root dir IMO
@robstoll robstoll merged commit d15fac6 into main Jun 20, 2023
@robstoll robstoll deleted the build-logic branch June 20, 2023 21:14
@robstoll robstoll added this to the 1.1.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants