Overload deprecate in chronoZoned context #1204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstoll
requested changes
Oct 13, 2022
Owner
robstoll
left a comment
There was a problem hiding this comment.
Looks all good, only a small issue regarding useless lines
..._GB/src/jvmMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/chronoZonedDateTimeExpectations.kt
Outdated
Show resolved
Hide resolved
robstoll
reviewed
Oct 13, 2022
..._GB/src/jvmMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/chronoZonedDateTimeExpectations.kt
Outdated
Show resolved
Hide resolved
robstoll
approved these changes
Oct 13, 2022
Owner
|
@JordanllHarper I just merged your first contribution to Atrium 🎉 How about another one? And don't forget to ⭐ Atrium if you liked it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented the overloads and deprecations on chronoZonedDateTime functions for both API's and put them at the top of both files. If these need to be moved to a specific file, I'm happy to do so.
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.