Add samples for fileAssertions (#944) #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstoll
requested changes
Oct 18, 2021
...um-api-fluent-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/fluent/en_GB/fileAssertions.kt
Outdated
Show resolved
Hide resolved
...um-api-fluent-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/fluent/en_GB/fileAssertions.kt
Outdated
Show resolved
Hide resolved
..._GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FileExpectationSamples.kt
Outdated
Show resolved
Hide resolved
..._GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FileExpectationSamples.kt
Outdated
Show resolved
Hide resolved
..._GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FileExpectationSamples.kt
Outdated
Show resolved
Hide resolved
..._GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FileExpectationSamples.kt
Outdated
Show resolved
Hide resolved
..._GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FileExpectationSamples.kt
Outdated
Show resolved
Hide resolved
..._GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FileExpectationSamples.kt
Outdated
Show resolved
Hide resolved
..._GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FileExpectationSamples.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Contributor
Author
|
Thanks for the Review, @robstoll I made the requested changes |
robstoll
requested changes
Oct 21, 2021
..._GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FileExpectationSamples.kt
Outdated
Show resolved
Hide resolved
..._GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FileExpectationSamples.kt
Outdated
Show resolved
Hide resolved
robstoll
approved these changes
Oct 21, 2021
Codecov Report
@@ Coverage Diff @@
## main #1017 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 433 433
Lines 4374 4374
Branches 221 221
=======================================
Hits 3973 3973
Misses 352 352
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Owner
|
@iljakorneckis thanks for your first contribution to Atrium 👍 |
Contributor
Author
|
@robstoll Woo! 🙌 Thank you for this awesome project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #994
Quick note: I added the samples to the -jvm project (not in -common, as it states in the issue), as that where the fileAssertions.kt are located. If this is incorrect, I'll make the necessary changes asap.
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.