-
Notifications
You must be signed in to change notification settings - Fork 785
Description
The current alert related keywords are a mess. Biggest problems:
-
Selecting should the alert be dismissed by pressing
OkorCancelneeds to be done using separateChoose Ok/Cancel On Next Confirmationkeywords. I think there used to be a technical reason to do it this way, but looking at the current code this doesn't seem to be the case. Much better to just pass this information as a normal argument to keywords dismissing alerts. -
There are several keywords with same/similar functionality. In practice
Confirm Action,Dismiss AlertanGet Alert Messageall close the alert by default. -
Strange configuration options and default values. For example,
Dismiss Alertactually accepts the alert by default and needs to be separately configured to dismiss it.
If I've understood it correctly, there can be three kind of Javascript alerts:
- An alert with a message and Ok button (
window.alert). - An alert with a message and Ok/Cancel buttons (
window.confirm) - An alert with a message, text input field, and Ok/Cancel buttons (
window.prompt)
We need to think what kind of a set of keywords are needed to handle these different alerts. The more we can keep backwards compatibility (i.e. keyword names) the better, but the most important goal is making the set of keywords consistent and easy to use.