fix: allow workflow input selectors for motion detection parameters #1898
+34
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8eb4cde to
4dba085
Compare
grzegorz-roboflow
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When linking workflow input parameters to Motion Detection block properties (Minimum Contour Area, Morphological Kernel Size, Threshold, History), Pydantic would throw:
This happened because
gt=0was applied at the Field level, which affects all types in the Union including the Selector string.Solution:
Use
PositiveInt(a Pydantic type with built-in> 0constraint) as the first type in the Union instead ofintwithgt=0on the Field. This ensures the constraint only applies when an actual integer is provided, not when a selector string is passed.This follows the pattern used by other blocks like Image Slicer.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
tested via unit tests
Any specific deployment considerations
standard deploy
Docs