Remove extra detections_rollup folder #1876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a duplicate detections_rollup folder that was inadvertently left behind after a block renaming in PR 1853. The correct implementation exists in the detections_list_rollup folder, which is properly imported and used throughout the codebase.
Key changes:
- Removal of duplicate implementation file (
detections_rollup/v1.py) - Cleanup of duplicate package structure
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
inference/core/workflows/core_steps/fusion/detections_rollup/v1.py |
Removes duplicate implementation of DetectionsListRollUpBlockV1 (1154 lines) - the correct version exists in detections_list_rollup/v1.py |
inference/core/workflows/core_steps/fusion/detections_rollup/__init__.py |
Empty init file for the duplicate package being removed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
grzegorz-roboflow
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR 1853 added a detections rollup block - an extra folder was left in there due to a block renaming, so adding this PR to remove it.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Existing test cases cover the change.
Any specific deployment considerations
N/A
Docs