Fix small bug in motion detection #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in motion detection where the background subtraction model was not being initialized properly. The background subtractor needs to process frames to build its model, but the code was previously checking frame initialization status before applying background subtraction, preventing the model from learning until the time limit was reached.
Key Changes:
- Moved background subtraction call before the frame initialization check, allowing the model to process frames during the initialization period
- Refactored the initialization condition logic for clarity
- Removed unused variables and improved contour filtering
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
inference/core/workflows/core_steps/classical_cv/motion_detection/v1.py
Outdated
Show resolved
Hide resolved
…ion/v1.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
grzegorz-roboflow
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motion detection has an option to not start detection motion until the background is initialized. The order of the code however was actually preventing the background from initializing until the time limit hit. This is a very small change to fix the issue. Also filtering out contours of < 3 points earlier rather than hold onto them.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested locally and with test cases
Any specific deployment considerations
N/A
Docs
N/A