add dinov3 to inference experimental #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inference_experimental/inference_exp/models/dinov3/dinov3_classification_onnx.py
Outdated
Show resolved
Hide resolved
Collaborator
PawelPeczek-Roboflow
left a comment
There was a problem hiding this comment.
looks good - I would like to clarify the model packages content
- in tests - could we assert the predictions values - I believe it's possible to get assertions with reasonable bounds to reflect changes in numerics across different platforms
PawelPeczek-Roboflow
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Added tests to CI
Any specific deployment considerations
N/A
Docs
N/A