EncryptedSinks pass IV and Key in constructor (Fixes for #35) #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated EncryptedSinks with abstract base class and additional constructor to pass in IV Added additional tests for encryption/decryption repeatability when the decrpytion IV is known Resolved some Xunit errors Package updates and consolidation to latest Xunit Fixed na issue with with the Xunit FileData attribute only finding a single file per test
Owner
|
Looks great actually, thanks a lot for this effort! |
Owner
Owner
|
Help me document it? https://github.com/robinrodricks/FluentStorage/wiki/Data-Encryption |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Issue #35
New constructor for
SymmetricEncryptionSinkandAesSymmetricEncryptionSinkto pass IV and keyUpdated
EncryptedSinkabstract base class with additional constructor to pass in IVAdded additional tests for encryption/decryption repeatability when the decrpytion IV is known
Resolved some Xunit errors
Package updates and consolidation to latest Xunit
Fixed issue with with the Xunit FileData attribute only finding a single file per test
add your description