Add option to store passphrase in localstorage or sessionstorage#122
Closed
thomasmarr wants to merge 2 commits intorobinmoisson:gh-pagesfrom
Closed
Add option to store passphrase in localstorage or sessionstorage#122thomasmarr wants to merge 2 commits intorobinmoisson:gh-pagesfrom
thomasmarr wants to merge 2 commits intorobinmoisson:gh-pagesfrom
Conversation
Author
|
@robinmoisson would appreciate it if you could take a look at this PR, thanks. If you don't plan to merge please let me know. |
epicfaace
reviewed
Feb 15, 2021
Contributor
epicfaace
left a comment
There was a problem hiding this comment.
This is great -- thanks for doing this!
Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
Owner
|
Hey @thomasmarr thanks a lot for PR, it's helpful! And so sorry for taking so long to answer. I read it and the related discussion, the approach that makes the more sense to me is adding a "Remember me" checkbox with optional expiration so that's what I implemented in #124 (feel free to comment there if you'd like). So I'm closing this one, thanks again for opening it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR leans heavily on code written by @epicfaace, referenced in issue #120. Original gist here.
An option has been added to the CLI to permit the user to select between localStorage, sessionStorage, or None.