upgrade clap to 4 #304
Merged
upgrade clap to 4 #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeggse
reviewed
Mar 24, 2024
| clap::Arg::new("table") | ||
| .long_help("Table sources to load. Table option can be provided as optional setting as part of the table URI, for example: `blogs=s3://bucket/key,format=delta`. Set table uri to `stdin` if you want to consume table data from stdin as part of a UNIX pipe. If no table_name is provided, a table name will be derived from the filename in URI.") | ||
| .takes_value(true) | ||
| .num_args(1) |
There was a problem hiding this comment.
I'm not sure if this was intended, but this seems to have made the option only usable once - you can't pass --table multiple times for columnq console.TheREADME.mdincludes an example with multiple--table` arguments, and that seems unsupported:
error: the argument '--table <[table_name=]uri[,option_key=option_value]>' cannot be used multiple times
Usage: columnq console [OPTIONS]
For more information, try '--help'.
There was a problem hiding this comment.
Yeah, installing 51584dd fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.