#240 Set object_store minimal version and turn on aws_profile feature #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jychen7
commented
Jan 19, 2023
|
|
||
| datafusion = "14" | ||
| object_store = "0.5.0" | ||
| object_store = { version = "0.5.3", features = ["aws_profile"] } |
Collaborator
Author
There was a problem hiding this comment.
the feature aws_profile was introduced since 0.5.2. I set minimum to 0.5.3 as it is latest one as of today and helps remove simplify code a bit in columnq/src/columnq.rs
https://github.com/apache/arrow-rs/blob/master/object_store/CHANGELOG-old.md#object_store_052-2022-12-02
ps: Cargo.lock already use 0.5.3 anyway
Lines 2794 to 2796 in bd168d9
This was referenced Jan 19, 2023
Merged
houqp
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
address comment #245 (comment)