fix(connection): improve connection closing and error handling#309
Merged
bittcrafter merged 1 commit intormqtt:masterfrom Sep 24, 2025
Merged
fix(connection): improve connection closing and error handling#309bittcrafter merged 1 commit intormqtt:masterfrom
bittcrafter merged 1 commit intormqtt:masterfrom
Conversation
Collaborator
bittcrafter
commented
Sep 24, 2025
- Move sink.close() earlier in session termination process with proper error logging
- Add connection close with error logging when MQTT connection is refused in v3 and v5 protocols
- Maintain existing disconnect logic while ensuring proper resource cleanup
- Improve error visibility by logging IO close errors in connection refusal scenarios
* Move sink.close() earlier in session termination process with proper error logging * Add connection close with error logging when MQTT connection is refused in v3 and v5 protocols * Maintain existing disconnect logic while ensuring proper resource cleanup * Improve error visibility by logging IO close errors in connection refusal scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.