feat(plugins): enhance configuration handling with defaults and better error reporting#266
Merged
bittcrafter merged 1 commit intormqtt:masterfrom Aug 26, 2025
Merged
Conversation
…r error reporting Version Updates: - Bumped multiple plugin versions for configuration improvements: * rmqtt-acl: 0.1.2 → 0.1.3 * rmqtt-auth-jwt: 0.1.1 → 0.1.2 * rmqtt-http-api: 0.2.1 → 0.2.2 * rmqtt-message-storage: 0.1.4 → 0.1.5 * rmqtt-retainer: 0.1.2 → 0.1.3 * rmqtt-session-storage: 0.2.1 → 0.2.2 * rmqtt-sys-topic: 0.1.2 → 0.1.3 Configuration Improvements: - **Default Configurations**: Added default rules and storage configurations - **Better Error Messages**: Enhanced JWT auth error logging with token context - **Storage Validation**: Added explicit error for missing storage engine specification Key Changes: 1. **ACL Plugin**: - Added default ACL rules for dashboard and localhost access - Improved rule parsing with better error handling - Added toml dependency for configuration parsing 2. **Storage Plugins**: - Added default storage engine selection based on enabled features - Better error messages when no storage engine is configured - Changed storage fields to `Option<T>` with defaults 3. **Logging Improvements**: - Changed debug logs to info for better visibility of loaded configurations - Enhanced JWT error messages to include the problematic token 4. **Configuration API**: - Unified use of `read_config_default` for optional configurations - Maintained backward compatibility with existing config files Benefits: - **Out-of-box Experience**: Plugins work with sensible defaults - **Better Debugging**: More informative error messages - **Robustness**: Explicit handling of missing configurations - **Maintainability**: Consistent configuration pattern across plugins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version Updates:
Configuration Improvements:
Key Changes:
ACL Plugin:
Storage Plugins:
Option<T>with defaultsLogging Improvements:
Configuration API:
read_config_defaultfor optional configurationsBenefits: