Use Argument names as configured (fix args with numbers)#2792
Merged
Use Argument names as configured (fix args with numbers)#2792
Conversation
This was referenced Mar 2, 2020
Contributor
|
Thanks for tackling this @rmosolgo. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, GraphQL-Ruby doesn't use the provided symbol to build keyword arguments, which is confusing.
So instead, if
argument(...)is configured with a symbol, use the given symbol for the method's keyword arguments.This can break existing configurations if they configured arguments with camelized symbols, but expected underscored arguments in their methods (see the change in the test suite, for example).
Fixes #2611
Fixes #2654 (this approach maintains current behavior)
Fixes #2706
Fixes #1839