feat(memory): add skills-index.md registry for O(1) skill lookup#1224
Merged
Conversation
Implements the Skills Index Registry (PRD from issue #581) providing: - Central registry of 345 skills across 34 domains - Quick navigation table for domain-level browsing - Skill ID naming convention (Skill-{Domain}-{Number}) - Skill lifecycle states (Draft, Active, Deprecated) - Creation and deprecation process documentation Fixes #581 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
PR Validation ReportCaution ❌ Status: FAIL Description Validation
QA Validation
|
Contributor
Pass: Memory HealthMemory Health Report[PASS] 47/47 memories healthy
Summary: 47 healthy, 0 stale, 0 exempt, 0 errors Health Check Details
|
Contributor
✅ Pass: Memory ValidationNo memories with citations found. 📊 Validation Details
|
README Troubleshooting section uses <code> inside <summary> tags, which is standard HTML for details/summary disclosure widgets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 4❌ Failed checks (4 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.markdownlint-cli2.yaml (1)
48-53:⚠️ Potential issue | 🟡 MinorAdd a business‑reason comment for the MD033 change.
Rule modifications must include inline rationale. Adding
codeto allowed elements is a rule change but has no specific reason documented.Proposed fix
MD033: allowed_elements: - br + # Allow inline code inside <summary> blocks in README troubleshooting - code - kbdAs per coding guidelines, "Never disable or modify linting rules without documenting the rationale with inline comments explaining the business reason."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.markdownlint-cli2.yaml around lines 48 - 53, You added `code` to MD033's allowed_elements without documenting the business rationale; update the `.markdownlint-cli2.yaml` MD033 section to include an inline comment explaining why `code` is permitted (e.g., required for rendering inline code snippets from user-generated docs or API responses) so reviewers can see the explicit business reason for modifying the rule; reference the MD033 rule and the allowed_elements list in your comment to make the intent clear.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.markdownlint-cli2.yaml:
- Around line 48-53: You added `code` to MD033's allowed_elements without
documenting the business rationale; update the `.markdownlint-cli2.yaml` MD033
section to include an inline comment explaining why `code` is permitted (e.g.,
required for rendering inline code snippets from user-generated docs or API
responses) so reviewers can see the explicit business reason for modifying the
rule; reference the MD033 rule and the allowed_elements list in your comment to
make the intent clear.
This was referenced Feb 22, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skill-{Domain}-{Number}Changes
.serena/memories/skills-index.mdwith:Test Plan
Fixes #581
Generated with Claude Code