-
-
Notifications
You must be signed in to change notification settings - Fork 10
agent/qa: Add mandatory pre-PR quality gate enforcement #258
Copy link
Copy link
Closed
Labels
agent-implementerCode implementation agentCode implementation agentagent-orchestratorTask coordination agentTask coordination agentagent-qaTesting and verification agentTesting and verification agentagent-securitySecurity assessment agentSecurity assessment agentarea-infrastructureBuild, CI/CD, configurationBuild, CI/CD, configurationarea-skillsSkills documentation and patternsSkills documentation and patternsarea-workflowsGitHub Actions workflowsGitHub Actions workflowsbugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestpriority:P1Important: Affects user experience significantly, high business valueImportant: Affects user experience significantly, high business value
Metadata
Metadata
Assignees
Labels
agent-implementerCode implementation agentCode implementation agentagent-orchestratorTask coordination agentTask coordination agentagent-qaTesting and verification agentTesting and verification agentagent-securitySecurity assessment agentSecurity assessment agentarea-infrastructureBuild, CI/CD, configurationBuild, CI/CD, configurationarea-skillsSkills documentation and patternsSkills documentation and patternsarea-workflowsGitHub Actions workflowsGitHub Actions workflowsbugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestpriority:P1Important: Affects user experience significantly, high business valueImportant: Affects user experience significantly, high business value
@
Context
PR #249 analysis showed QA agent involvement AFTER PR opening, not before. All 7 P0-P1 bugs could have been caught with pre-PR quality gates.
Evidence:
Problem
The qa agent (482 lines) has quality standards but no enforcement mechanism BEFORE PR creation:
Has:
Missing:
Proposed Solution
Add Pre-PR Quality Gate section to src/claude/qa.md before "Test Strategy Development" section.
New Section
Step 2: Verify Fail-Safe Patterns
Step 3: Test-Implementation Alignment
Step 4: Quality Gate Evidence
Generate evidence file:
.agents/qa/pre-pr-validation-[feature].mdHandoff to Orchestrator
After validation:
If BLOCKED, orchestrator routes back to implementer for fixes.
If APPROVED, orchestrator authorizes PR creation.