Skip to content

Commit a13f82e

Browse files
rjmurillo-botclaude
rjmurillo-bot
and
claude
committed
fix(docs): correct GitHub Actions syntax in retrospective
Replace `@{{ }}` with `${{ }}` in 7 locations. The `@{{ }}` syntax was incorrectly used when documenting GitHub Actions template expressions. The correct syntax is `${{ expression }}` for template variables. Fixes: - Line 412: Bot @mention protocol skill - Line 445: SMART validation section - Line 550: Skill statement - Line 563: Pattern example - Line 684: Learning extraction - Line 754: JSON structure - Line 893: Priority table 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent c5d0649 commit a13f82e

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

‎.agents/retrospective/2025-12-20-session-38-comprehensive.md‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@
409409
| Finding | Proposed Skill ID | Statement |
410410
|---------|-------------------|-----------|
411411
| GraphQL for thread resolution | Skill-GitHub-GraphQL-001 | GitHub review thread resolution requires GraphQL API; REST API is read-only |
412-
| Bot @mention protocol | Skill-PR-Automation-001 | Bot PR authors need @mention to trigger action on feedback; use `@{{ github.event.pull_request.user.login }}` |
412+
| Bot @mention protocol | Skill-PR-Automation-001 | Bot PR authors need @mention to trigger action on feedback; use `${{ github.event.pull_request.user.login }}` |
413413
| dorny/paths-filter checkout | Skill-CI-Workflows-001 | dorny/paths-filter requires checkout step in ALL jobs, not just the job using the filter |
414414
| Infrastructure health check | Skill-Agent-Infra-001 | Verify agent infrastructure (Copilot CLI, MCP) before invocation; separate environment errors from quality findings |
415415
| Homework scanning pattern | Skill-Maintenance-002 | Search merged PRs for "Deferred to follow-up", "TODO", "future improvement"; 20% hit rate justifies automation |
@@ -442,7 +442,7 @@
442442

443443
#### Proposed Skill 2: Bot @mention Protocol
444444

445-
**Statement**: Bot PR authors need @mention to trigger action on feedback; use `@{{ github.event.pull_request.user.login }}`
445+
**Statement**: Bot PR authors need @mention to trigger action on feedback; use `${{ github.event.pull_request.user.login }}`
446446

447447
**Validation**:
448448

@@ -547,7 +547,7 @@
547547

548548
#### Learning 2: Bot Author @mention Protocol
549549

550-
**Statement**: Bot PR authors need @mention to trigger action; use `@{{ github.event.pull_request.user.login }}`
550+
**Statement**: Bot PR authors need @mention to trigger action; use `${{ github.event.pull_request.user.login }}`
551551

552552
**Scoring**:
553553
- Compound statements: 1 ("need" + "use") (-15%)
@@ -560,7 +560,7 @@
560560

561561
**Refinement**: Split into two statements
562562
- Statement A: "Bot PR authors need @mention to detect feedback requiring action"
563-
- Statement B: "Use `@{{ github.event.pull_request.user.login }}` to notify PR author in workflow comments"
563+
- Statement B: "Use `${{ github.event.pull_request.user.login }}` to notify PR author in workflow comments"
564564

565565
**Refined Score**: 95% (Statement A), 92% (Statement B)
566566

@@ -681,7 +681,7 @@
681681

682682
### Learning 2B: Bot Notification Syntax
683683

684-
- **Statement**: Use `@{{ github.event.pull_request.user.login }}` to notify PR author in workflow comments
684+
- **Statement**: Use `${{ github.event.pull_request.user.login }}` to notify PR author in workflow comments
685685
- **Atomicity Score**: 92%
686686
- **Evidence**: Issue #152 implementation guidance
687687
- **Skill Operation**: ADD
@@ -751,7 +751,7 @@
751751
},
752752
{
753753
"skill_id": "Skill-PR-Automation-002",
754-
"statement": "Use @{{ github.event.pull_request.user.login }} to notify PR author in workflow comments",
754+
"statement": "Use ${{ github.event.pull_request.user.login }} to notify PR author in workflow comments",
755755
"context": "When posting workflow feedback requiring author action",
756756
"evidence": "Issue #152 implementation guidance for AI Quality Gate enhancement",
757757
"atomicity": 92
@@ -890,7 +890,7 @@
890890
|----------|-----------|-----------|-----------|--------|
891891
| Skill-GitHub-GraphQL-001 | GitHub review thread resolution requires GraphQL API; REST API is read-only | 100% | ADD | - |
892892
| Skill-PR-Automation-001 | Bot PR authors need @mention to detect feedback requiring action | 95% | ADD | - |
893-
| Skill-PR-Automation-002 | Use @{{ github.event.pull_request.user.login }} to notify PR author in workflow comments | 92% | ADD | - |
893+
| Skill-PR-Automation-002 | Use ${{ github.event.pull_request.user.login }} to notify PR author in workflow comments | 92% | ADD | - |
894894
| Skill-CI-Workflows-001 | dorny/paths-filter requires checkout in ALL jobs, not just the job using the filter | 98% | ADD | - |
895895
| Skill-Agent-Infra-001 | Check Copilot CLI availability before invoking architect agent; exit code 1 may indicate infrastructure failure | 88% | ADD | - |
896896
| Skill-Agent-Diagnosis-001 | Distinguish agent execution errors (environment) from agent findings (code quality) | 90% | ADD | - |

0 commit comments

Comments
 (0)