use rune type instead of int for unicode tables#61
Open
Luap99 wants to merge 1 commit into
Open
Conversation
int is 64 bit on 64 bit platforms but each unicode char is only 32bit and go APIs generally use rune as type for it so switch to that. The main motivation is to reduce the binary size with a small example program I see a about 170k reduce binary size footprint. Note I went with minimal changes in terms of changing the API of various internal functions and cast back to int quite early. In theory one could make much more changes to use rune over int. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Author
|
@rivo Could you take look here please? |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
int is 64 bit on 64 bit platforms but each unicode char is only 32bit and go APIs generally use rune as type for it so switch to that.
The main motivation is to reduce the binary size with a small example program I see a about 170k reduce binary size footprint.
Note I went with minimal changes in terms of changing the API of various internal functions and cast back to int quite early. In theory one could make much more changes to use rune over int.