fix(v8-runtime): shorten macOS bootstrap UDS socket path#62
Merged
NathanFlurry merged 1 commit intorivet-dev:mainfrom Mar 30, 2026
Merged
Conversation
- Cut random suffix from 128-bit to 64-bit - Reduce macOS tmpdir socket path length risk
Member
|
you just shorted my todo list for the evening, absolute legend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60
Summary
sun_pathlimits under long macOSTMPDIRrootsstdout before sending socket pathVerification
pnpm exec tsx examples/quickstart/src/simple.tsfails on macOS before this change with defaultTMPDIRpnpm exec tsx examples/quickstart/src/simple.tssucceeds on macOS after this change with defaultTMPDIRfailed to bind UDS: path must be shorter than SUN_LENTo the best of my knowledge, this is the best fix. The 32bit random suffix still provides plenty of available sockets. Happy to provide any additional information, or go about fixing this in a different way if needed.