Merged
Conversation
|
🚅 Deployed to the sandbox-agent-pr-206 environment in sandbox-agent
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional
waitForHealthgate toSandboxAgent.connect()so one startup health promise blocks both HTTP helpers and ACP session setup until/v1/healthsucceeds.Update the direct remote examples to use
SandboxAgent.connect({ waitForHealth: { timeoutMs: 120_000 } })instead of manually polling before connect.Add integration coverage for non-ACP request gating and for surfacing a timeout when a real request awaits readiness.
Verification
Automated TypeScript checks were not runnable in this workspace because
tscandvitestare unavailable without installednode_modules.