put user-facing bundle in uiendpoints #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
brandur
approved these changes
Aug 16, 2025
b08b92e to
6df5950
Compare
A mistake was made in #379 by including internal types in user-facing structs and as arguments, specifically by exposing things from the `internal/apibundle` package like `EndpointsBundle`. To rectify this, move user-facing types into a top-level `uiendpoints` package (not internal) which now includes a `Bundle` and `BundleOpts` type that can be referenced both from `riverui` and from packages in `internal` without creating a dependency loop.
3ffe130 to
7c0fca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mistake was made in #379 by including internal types in user-facing
structs and as arguments, specifically by exposing things from the
internal/apibundlepackage likeEndpointsBundle. To rectify this,move user-facing types into a top-level
uiendpointspackage (notinternal) which now includes a
BundleandBundleOptstype that canbe referenced both from
riveruiand from packages ininternalwithout creating a dependency loop.