rename Server + ServerOpts to Handler + HandlerOpts #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cec0def to
b08b92e
Compare
brandur
approved these changes
Aug 16, 2025
Although it must be "started" for its background caching routine to function, this type ultimately still functions as an `http.Handler` which can be embedded into an `http.ServeMux` or other handler-compatible router. It does _not_ function as an `http.Server` and the prior naming caused confusion in this regard. Bite the bullet on the breaking rename while we already have other breaking changes going out for the endpoints concept.
b08b92e to
6df5950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it must be "started" for its background caching routine to function, this type ultimately still functions as an
http.Handlerwhich can be embedded into anhttp.ServeMuxor other handler-compatible router. It does not function as anhttp.Serverand the prior naming caused confusion in this regard.Bite the bullet on the breaking rename while we already have other breaking changes going out for the endpoints concept.