Collapsible JSON view #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97a8e1d to
cddacd8
Compare
cddacd8 to
d946f97
Compare
brandur
approved these changes
May 11, 2025
Collaborator
brandur
left a comment
There was a problem hiding this comment.
Slick man!!!! Love it, and I think users will too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we start looking at having larger metadata payloads (for job logs) the prior approach of pretty-printing the entire thing on screen is unsustainable. This is also true for users with large arg payloads.
As such, move to an interactive collapsible JSON tree view. By default, it expands the first level and collapses any nested arrays or objects.
collapse.mp4