fix frontend type issues with split Job type #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually this needs a few more tweaks to the factory setup, will get to that shortly! |
Issue #347 details how #344 broke some key parts of the frontend due to missing fields in the job list payloads (errors, logs, and metadata were removed from the job payload for the list API). The root issue is that the TypeScript types were not adjusted to reflect the new split Job type, so several parts of the code made reference to things they could no longer access (and didn't actually need anyway). In particular this was true for deserializing job payloads where the same logic was applied to all job responses. To fix this, update the types to have a separate `JobMinimal` and `Job` type just as the API backend does. Update all code that uses them to ensure the correct one is utilized. It's only list view stuff that needs `JobMinimal` for now. Fixes #347.
e56c768 to
9f87cf0
Compare
brandur
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #347 details how #344 broke some key parts of the frontend due to missing fields in the job list payloads (errors, logs, and metadata were removed from the job payload for the list API). The root issue is that the TypeScript types were not adjusted to reflect the new split Job type, so several parts of the code made reference to things they could no longer access (and didn't actually need anyway). In particular this was true for deserializing job payloads where the same logic was applied to all job responses.
To fix this, update the types to have a separate
JobMinimalandJobtype just as the API backend does. Update all code that uses them to ensure the correct one is utilized. It's only list view stuff that needsJobMinimalfor now.Fixes #347.