Skip to content

Prefix not respected throughout the UI #352

@Baker

Description

@Baker

Issue

I noticed prefix is not being respected throughout the entire UX of RiverUI. Specifically with any of the "queue" related paths.

Examples:

https://i.imgur.com/op8xCnW.png (The prefix I am using is ui, see Sample code for example)

Sample Code

This is the main parts of the code that matter - but lmk if you want something else as well.

r := gin.New()
r.GET("/ui/*any", RiverUi(db, logger, client))


func RiverUi(db *gorm.DB, logger *zap.Logger, client *queue_client.RiverClient) gin.HandlerFunc {
	// Create a pgx connection pool
	pgxPool, err := pgxpool.New(context.Background(), database.BuildDSN())
	if err != nil {
		logger.Fatal("Failed to create pgx pool", zap.Error(err))
	}
	server, err := riverui.NewServer(&riverui.ServerOpts{
		Client: client.ExecutionClient,
		DB:     pgxPool,
		Logger: utils.NewSlogLogger(logger),
		Prefix: "/ui",
	})
	if err != nil {
		logger.Fatal("Failed to create River UI server", zap.Error(err))
	}
	if err := server.Start(context.Background()); err != nil {
		logger.Fatal("Failed to start River UI server", zap.Error(err))
	}
	return gin.WrapH(server)
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions