Skip to content

refactor: remove legacy java frontend#2519

Merged
fuyufjh merged 9 commits into
mainfrom
eric/remove_legacy_frontend
May 14, 2022
Merged

refactor: remove legacy java frontend#2519
fuyufjh merged 9 commits into
mainfrom
eric/remove_legacy_frontend

Conversation

@fuyufjh

@fuyufjh fuyufjh commented May 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What's changed and what's your intention?

Remove legacy Java frontend, including sources and tests.

TO REVIEWERS: Click this link to see diffs excluding removing legacy folder -> https://github.com/singularity-data/risingwave/pull/2519/files/2ef98f693fb42eeb1bf0df3facfa95549f4b35f2..HEAD

Some remaining works need to be done later:

  • Check E2E test cases and make sure all cases are covered in v2/ before removing them
  • Migrate regress tests src/tests/regress/ to Rust frontend and enable them
  • Remove compatible code in backend (keyword: is_legacy_frontend)
  • Remove CreateSourceExecutor
  • Remove create_materialized_view and drop_materialized_view in StreamServiceImpl should we depracate StreamServiceImpl's usused functions? #2260
  • Rename all occurrences of "FrontendV2" to "Frontend"

Checklist

N/A

Refer to a related PR or issue link (optional)

None

@github-actions github-actions Bot added the type/refactor Type: Refactoring. label May 14, 2022
@codecov

codecov Bot commented May 14, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2519 (0457bea) into main (e4a0c3a) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2519      +/-   ##
==========================================
+ Coverage   71.33%   71.40%   +0.06%     
==========================================
  Files         689      688       -1     
  Lines       88643    88531     -112     
==========================================
- Hits        63232    63213      -19     
+ Misses      25411    25318      -93
Flag Coverage Δ
rust 71.40% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/array/struct_array.rs 83.58% <0.00%> (-0.92%) ⬇️
src/risedevtool/src/task.rs 0.00% <0.00%> (ø)
src/risedevtool/src/config.rs 0.00% <0.00%> (ø)
src/frontend/src/binder/values.rs 92.68% <0.00%> (ø)
src/risedevtool/src/service_config.rs 0.00% <0.00%> (ø)
src/risedevtool/src/task/frontend_service.rs
src/risedevtool/src/bin/risedev-config.rs 0.44% <0.00%> (+0.01%) ⬆️
src/risedevtool/src/bin/risedev-compose.rs 1.12% <0.00%> (+0.01%) ⬆️
src/risedevtool/src/bin/risedev-playground.rs 0.30% <0.00%> (+0.01%) ⬆️
src/storage/src/hummock/local_version_manager.rs 89.88% <0.00%> (+0.03%) ⬆️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

skyzh
skyzh approved these changes May 14, 2022
View reviewed changes

@skyzh skyzh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Comment thread risedev.yml Outdated
@D2Lark

D2Lark commented May 14, 2022

Copy link
Copy Markdown
Contributor

some meta service used by legacy java frontend can be removed~ like this

@TennyZhuang

TennyZhuang commented May 14, 2022

Copy link
Copy Markdown
Contributor

some meta service used by legacy java frontend can be removed~ like this

For review, We can do it in another PR!

@TennyZhuang

TennyZhuang commented May 14, 2022

Copy link
Copy Markdown
Contributor

How about tag a new version?

@fuyufjh

fuyufjh commented May 14, 2022

Copy link
Copy Markdown
Contributor Author

How about tag a new version?

Good idea! Just pushed a new tag v0.1.7. The release pipeline has been triggered. https://github.com/singularity-data/risingwave/actions/runs/2324374089

@fuyufjh

fuyufjh commented May 14, 2022

Copy link
Copy Markdown
Contributor Author

some meta service used by legacy java frontend can be removed~ like this

Added to the todo list in PR description. Let's open a tracking issue and do these later.

@fuyufjh fuyufjh merged this pull request into main May 14, 2022
@fuyufjh fuyufjh deleted the eric/remove_legacy_frontend branch May 14, 2022 15:22
@TennyZhuang TennyZhuang restored the eric/remove_legacy_frontend branch May 14, 2022 15:24
@fuyufjh fuyufjh mentioned this pull request May 14, 2022
Merged
@fuyufjh fuyufjh deleted the eric/remove_legacy_frontend branch May 14, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liurenjie1024 liurenjie1024 Awaiting requested review from liurenjie1024

@neverchanje neverchanje Awaiting requested review from neverchanje

1 more reviewer

@skyzh skyzh skyzh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/refactor Type: Refactoring.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fuyufjh @D2Lark @TennyZhuang @skyzh