feat(storage-azdls): pick Add Azure Datalake Storage support (#1368)#74
Merged
xxhZs merged 4 commits intodev_rebase_main_20250325from Sep 29, 2025
Merged
Conversation
chenzl25
reviewed
Sep 23, 2025
c6edcdd to
2a50069
Compare
- Closes apache#1360. This PR adds an integration for the Azure Datalake storage service. At it's core, it adds parsing logic for configuration properties. The finished config struct is simply passed down to OpenDAL. In addition it adds logic to parse fully qualified file URIs, and matches it against expected (previously configured) values. It also creates a new `Storage::Azdls` enum variant based on OpenDAL's existing `Scheme::Azdls` enum variant. It then fits the parsing logic into the existing framework to build the storage integration from an `io::FileIOBuilder`. Other Iceberg ADLS integrations ([pyiceberg + Java](https://github.com/apache/iceberg-go/pull/313/files#r2021460617)) also support the `wasb://` and `wasbs://` schemes. WASB refers to a client-side implementation of hierarchical namespaces on top of Blob Storage. ADLS(v2) on the other hand is a service offered by Azure, also built on top of Blob Storage. IIUC we can accept both schemes because objects written to Blob Storage via `wasb://` will also be accessible via `adfs://` (which operates on the same Blob Storage). Even though the URIs slightly differ in format when they refer to the same object, we can largely reuse existing logic. ```diff -wasb[s]://<containername>@<accountname>.blob.core.windows.net/<path> +adfs[s]://<filesystemname>@<accountname>.dfs.core.windows.net/<path> ``` I added minor unit tests to validate the configuration property parsing logic. I decided **not** to add integration tests because 1. ADLS is not S3-compatible which means that we can't reuse our Minio setup 2. the Azure-specific alternative to local testing - Azurite - doesn't support ADLS I have yet to test it in a functioning environment. --------- Signed-off-by: Jannik Steinmann <jannik.steinmann@datadoghq.com>
2a50069 to
af79eae
Compare
xxhZs
approved these changes
Sep 25, 2025
…avelabs/iceberg-rust into li0k/pick_b5b8aa8_to_0325
chenzl25
approved these changes
Sep 26, 2025
Comment on lines
-155
to
-158
| pub(crate) fn s3_config_build( | ||
| client: &reqwest::Client, | ||
| cfg: &S3Config, | ||
| path: &str, |
Collaborator
There was a problem hiding this comment.
Please keep the crates/iceberg/src/io/storage_s3.rs unchanged, since the client inside the S3 is used to optimize the performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick apache#1368