Merged
Conversation
aswaterman
approved these changes
Oct 5, 2025
Member
|
Thanks for taking the time to improve the README. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 96.53% 97.13% +0.60%
==========================================
Files 10 12 +2
Lines 750 909 +159
==========================================
+ Hits 724 883 +159
Misses 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the example usage of parse.py in the README.
The previous example set the extensions to use by specifying an
EXTENSIONSvariable as a command line argument to thescript
parse.py. This does not work, instead extensions should beprovided directly without a variable
EXTENSIONS.The output of the script is misleading since no extensions are actually
used if the command passes them through "EXTENSIONS"
This can be tested by running a command like
then inspecting the generated file and noticing that the extensions
were not actually used, for example by checking the MATCH_ defines.
The command:
works.
I tested this on Linux using sh and bash shells with python3.13.2.