Delete OSX KQueue support from build.yaml (bdp 5.1/Netty 4.0.54)#23
Merged
dalaro merged 1 commit intoriptano:dse-netty-4.0.54.Finalfrom Jun 10, 2020
Conversation
Netty 4.0.x never had native KQueue transport in its source tree, so it makes no sense to run an osx/high-sierra 4.0.x build out of build.yaml. Deleting the OSX-specific logic branch and platform dependency declaration from build.yaml, while retaining the generic/ubuntu build logic and platform dependency. This commit shouldn't move forward to the Netty 4.1.x line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netty 4.0.x never had native KQueue transport in its source tree, so it makes no sense to run an osx/high-sierra 4.0.x build out of build.yaml. Deleting the OSX-specific logic branch and platform dependency declaration from build.yaml, while retaining the generic/ubuntu build logic and platform dependency. This commit shouldn't move forward to the Netty 4.1.x line.
An artifact built from this PR branch's HEAD has already become bdp 5.1-dev's Netty dependency. I'm just opening this github PR as a visible record of the change (as opposed to quietly merging locally and pushing).