Skip to content

Stop coercing ssl true in clickhouse cloud dsn save anyway #8543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lovincyrus merged 2 commits into from
Dec 19, 2025
Merged

Stop coercing ssl true in clickhouse cloud dsn save anyway #8543

lovincyrus merged 2 commits into from
Dec 19, 2025

Conversation

@lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented Dec 18, 2025 •
edited
Loading

This PR stops forcing ssl: true for ClickHouse Cloud DSN Save Anyway. This skips the ClickHouse Cloud SSL injection when the form payload contains a DSN. Closes https://linear.app/rilldata/issue/APP-659/save-anyways-bug-on-dsn-chc

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@lovincyrus lovincyrus self-assigned this Dec 18, 2025
@lovincyrus lovincyrus marked this pull request as ready for review December 18, 2025 17:37
royendo
royendo approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@royendo royendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

ericpgreen2
ericpgreen2 approved these changes Dec 18, 2025
View reviewed changes
@lovincyrus lovincyrus merged commit 3c5b9cb into main Dec 19, 2025
6 checks passed
@lovincyrus lovincyrus deleted the cyrus/no-ssl-in-clickhouse-dsn-save-anyway branch December 19, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

@royendo royendo royendo approved these changes

Assignees

@lovincyrus lovincyrus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lovincyrus @ericpgreen2 @royendo