Skip to content

docs: remove env configure #8531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
royendo merged 3 commits into from
Dec 18, 2025
Merged

docs: remove env configure #8531

royendo merged 3 commits into from
Dec 18, 2025

Conversation

@royendo
Copy link
Contributor

@royendo royendo commented Dec 17, 2025

Based on Conversation here:
https://rilldata.slack.com/archives/C01ADAYF1PZ/p1758873518079839?thread_ts=1758844685.882189&cid=C01ADAYF1PZ

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@royendo royendo requested a review from ericpgreen2 December 17, 2025 15:55
@begelundmuller begelundmuller mentioned this pull request Dec 18, 2025
Merged
@begelundmuller
Copy link
Contributor

begelundmuller commented Dec 18, 2025

@royendo Requested your review on the actual code removal here: #8536

ericpgreen2
ericpgreen2 approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix:

  • Typo in variables-and-credentials.md: "loca CLI" → "local CLI"

Future consideration:
The "Deploy to Rill Cloud" sections are now nearly identical across ~15 connector pages. If this text needs to change again, you might consider creating a reusable MDX component (similar to the existing Video or ConnectorIcon components) that accepts credentialType and connector props. Not necessary for this PR, but could simplify future maintenance.

Developed in collaboration with Claude Code

ericpgreen2
ericpgreen2 approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix:

  • Typo in variables-and-credentials.md: "loca CLI" → "local CLI"

Future consideration:
The "Deploy to Rill Cloud" sections are now nearly identical across ~15 connector pages. If this text needs to change again, you might consider creating a reusable MDX component (similar to the existing Video or ConnectorIcon components) that accepts credentialType and connector props. Not necessary for this PR, but could simplify future maintenance.

Developed in collaboration with Claude Code

@royendo royendo merged commit 4810df9 into main Dec 18, 2025
4 checks passed
@royendo royendo deleted the docs-remove-env-confiogure branch December 18, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@royendo @begelundmuller @ericpgreen2