-
Notifications
You must be signed in to change notification settings - Fork 162
[APP-397] feat: unify watch clients #8519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice work on this! The unified SSE endpoint is a solid approach for the connection limit issue, and the code is well-documented. One area to flag: the Design consideration:
The params approach works, but it makes the class fairly modal. It is worth considering whether the connection management logic (heartbeat, auto-close, reconnect) should live in a wrapper instead, keeping Minor items:
Happy to chat through any of this! Developed in collaboration with Claude Code |
|
@ericpgreen2 Reworked as a wrapper. |
Looks good! Let me know when ready for final review. |
ericpgreen2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Builds on #8504 and #8026 to unify the
WatchFilesClient,WatchResourcesClientandWatchRequestClientinto a singleFileAndResourceWatcher.SSEFetchClientChecklist: