Skip to content

Conversation

@k-anshul
Copy link
Member

@k-anshul k-anshul commented Dec 11, 2025

closes https://linear.app/rilldata/issue/PLAT-345/add-cli-commands-to-manage-devpreview-deployments

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@k-anshul k-anshul self-assigned this Dec 11, 2025
@k-anshul k-anshul marked this pull request as draft December 12, 2025 10:05
@k-anshul k-anshul marked this pull request as ready for review December 19, 2025 06:20
Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to support commands like rill project status and rill project refresh for non-primary deployments. Maybe with an optional --branch flag in those commands? Or were you planning on doing that in another PR?

Comment on lines +57 to +59
listCmd.Flags().StringVar(&project, "project", "", "Project name")
listCmd.Flags().StringVar(&path, "path", ".", "Project directory")
listCmd.Flags().StringVar(&environment, "environment", "", "Filter deployments by environment (prod/dev)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not important, but if easy it would be nice to add pagination here like for other listing APIs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not difficult but seems unnecessary ?
Even 20 deployments for a project would be too many ?

@k-anshul
Copy link
Member Author

I think we also need to support commands like rill project status and rill project refresh for non-primary deployments. Maybe with an optional --branch flag in those commands? Or were you planning on doing that in another PR?

Yeah that is on my radar and was planning to handle it in another PR.

@k-anshul k-anshul merged commit 367acf4 into main Dec 23, 2025
14 of 15 checks passed
@k-anshul k-anshul deleted the deployment_cli branch December 23, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants