-
Notifications
You must be signed in to change notification settings - Fork 162
feat: CLI to manage deployements #8484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0b7025f to
5dad5dd
Compare
5dad5dd to
76d33b3
Compare
76d33b3 to
1419abf
Compare
begelundmuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to support commands like rill project status and rill project refresh for non-primary deployments. Maybe with an optional --branch flag in those commands? Or were you planning on doing that in another PR?
| listCmd.Flags().StringVar(&project, "project", "", "Project name") | ||
| listCmd.Flags().StringVar(&path, "path", ".", "Project directory") | ||
| listCmd.Flags().StringVar(&environment, "environment", "", "Filter deployments by environment (prod/dev)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not important, but if easy it would be nice to add pagination here like for other listing APIs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not difficult but seems unnecessary ?
Even 20 deployments for a project would be too many ?
Yeah that is on my radar and was planning to handle it in another PR. |
closes https://linear.app/rilldata/issue/PLAT-345/add-cli-commands-to-manage-devpreview-deployments
Checklist: