Skip to content

Infinite scrolling in ShareProjectForm #8306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lovincyrus merged 9 commits into from
Dec 23, 2025
Merged

Infinite scrolling in ShareProjectForm #8306

lovincyrus merged 9 commits into from
Dec 23, 2025

Conversation

@lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented Nov 12, 2025 •
edited by cursor bot
Loading

INSERT DESCRIPTION HERE

Closes https://linear.app/rilldata/issue/APP-521/project-share-popover-is-not-displaying-full-list-of-users-that-have

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Note

Introduces paginated infinite loading for project members and invites to ensure full lists are shown and efficiently fetched.

  • Replaces single-page queries with createInfiniteQuery for projectMembers and projectInvites (PAGE_SIZE 10) and adds an IntersectionObserver to auto-fetch next pages
  • Consolidates results from infinite pages and preserves current-user-first ordering; adds a synthetic current-user row until their membership loads
  • Shows a lightweight "Loading more…" indicator while fetching next pages
  • Limits role editing UI in UserItem.svelte to users that actually have a roleName

Written by Cursor Bugbot for commit 591c413. This will update automatically on new commits. Configure here.

@lovincyrus lovincyrus self-assigned this Nov 12, 2025
@lovincyrus lovincyrus requested a review from ericokuma November 12, 2025 07:29
@lovincyrus
Copy link
Contributor Author

lovincyrus commented Nov 12, 2025

Ready for Product QA, modified the page size to 10. Will revert to 50 before landing this PR. @ericokuma

@ericokuma
Copy link
Contributor

ericokuma commented Nov 13, 2025

https://www.loom.com/share/4707f9d1da084faaba7a36337b4f9660

@lovincyrus Linear
Copy link
Contributor Author

lovincyrus commented Nov 13, 2025 •
edited
Loading

perfect, i'll address this

TODO: current user isn't loaded on dialog open.

@lovincyrus
Copy link
Contributor Author

lovincyrus commented Nov 14, 2025

perfect, i'll address thisTODO: current user isn't loaded on dialog open.

Filed a follow-up for endpoint request to properly address this: https://linear.app/rilldata/issue/APP-570/add-a-new-endpoint-to-get-current-users-project-membership-by-email

I've added a workaround in the meantime. Ready for re-review. The current user should now appear even when you haven't scroll to the bottom of the page. @ericokuma

@lovincyrus
Copy link
Contributor Author

lovincyrus commented Nov 18, 2025

To revert page size to 50 before merging.

ericokuma
ericokuma approved these changes Dec 23, 2025
View reviewed changes
Copy link
Contributor

@ericokuma ericokuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on the QA. This looks good!

@ericokuma ericokuma marked this pull request as ready for review December 23, 2025 00:16
cursor[bot]
cursor bot reviewed Dec 23, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@lovincyrus lovincyrus merged commit 64de6a5 into main Dec 23, 2025
9 checks passed
@lovincyrus lovincyrus deleted the cyrus/load-more-in-share-project-list branch December 23, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@ericokuma ericokuma ericokuma approved these changes

Assignees

@lovincyrus lovincyrus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lovincyrus @ericokuma