Skip to content

Import messages and core_messages in rpcq module init #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
notmgsk merged 1 commit into from
Dec 29, 2020
Merged

Import messages and core_messages in rpcq module init #146

notmgsk merged 1 commit into from
Dec 29, 2020

Conversation

@notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Dec 15, 2020

There might be a better way to do this. Thoughts?

Closes #137.

@notmgsk notmgsk requested a review from a team as a code owner December 15, 2020 22:54
erichulburd
erichulburd reviewed Dec 21, 2020
View reviewed changes
@erichulburd erichulburd self-requested a review December 22, 2020 21:25
@notmgsk notmgsk merged commit 8be5732 into master Dec 29, 2020
@notmgsk notmgsk mentioned this pull request Dec 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erichulburd erichulburd erichulburd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RPCQ from_json et al fail if rpcq.messages or rpcq.core_messages modules have not been loaded.

3 participants

@notmgsk @erichulburd