Extra filters option #108
Merged
Extra filters option #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… colorlevels for simpler brightness upscaling
rien
approved these changes
Oct 17, 2024
Owner
rien
left a comment
There was a problem hiding this comment.
Looking good. Thanks for the contribution!
I will wait a few days to see if the original implementer of the filter for the rm2 responds, but if not you can poke me again and I'll merge.
Contributor
Author
|
There is now a comment explaining what Maybe I need to specify that this closes #70 for Github to recognise it. I'll update the first comment. |
|
@rien Hi, that's looking great actually. Anything against merging it now, half a year later :) |
Owner
|
Whoops, this slipped my mind. Well, thanks for poking me 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
-e | --extra-filtersproposed in #70 .This will add the filter at the end of the program-set filters, because when testing with "negate" (#69 ), this seems to be the safer way.
Also fixed a missing comma (see fist commit)
Examples:
reStream.sh -e "avgblur=sizeX=12"reStream.sh -e "negate"reStream.sh -e "lutrgb=r='if(gte(val,0)*lte(val,85),255,0)':g='if(gte(val,85)*lte(val,170),255,0)':b='if(gte(val,170)*lte(val,255),255,0)'"(I'll experiment to see if is possible to let ffmpeg convert grayscale to some simple colours on the fly)
Arguments should be comma-seperated. I don't know if it would be necessary to add a check in the shell-script to see if it is valid output, or if we would just let it fail and let the user figure out what exactly went wrong.
The reason this is a draft PR, is for the above reason, and because I altered the way brightness is controlled. Instead of setting the max colorlevels for each color to 1/8th of their max (29/255), I used the curves filter to set the threshold at 1/8 = 0.125. The result looks the same, but it reads easier. I would like feedback about that.
Closes #70