This repository was archived by the owner on Aug 23, 2025. It is now read-only.
Use Tachyons for application styles #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike all the other stuff this was not a casualty of Tachyons
There's some funky absolute positioning stuff going on that needs to be refactored
Collaborator
Author
|
Taking the lack of input as an ok to go ahead with this. If anyone out there is like what is going on with the CSS in this app and finds this PR, and wants to chat or raise an issue or anything really please do not hesitate to reach out (for this or anything really). Next styling updates will be to make SQLPad a bit more "boring" and utilitarian. I think the bootstrap list/card things are going to be replaced with tables. Full screen forms, side nav. Then eventually rip bootstrap out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swaps out most the custom/application css for Tachyons classes. Eventually I'd like to replace bootstrap with basic components and Tachyons and simplify a lot of the UI to make it more utilitarian and basic.
Tachyons brings a lot of benefits and cleans up the lack of consistent styling strategy, but it brings some drawbacks too (people can't customize by overriding css classes, now people need to learn tachyons)
I personally think the benefits Tachyons brings outweigh the drawbacks, and I partially think making it harder to customize/override css classes is a good thing (if people want configurable styles or change the way it looks, contribute!)
That said - I'm going to leave this open for a few days in case anyone out there wants to try to convince me to not do this :)