5.4 dev npm update 2025 07 25#48
Conversation
|
@dgrammatiko Could you check the diff? It seems your PR adds an empty line with a space everywhere where the |
4fe4157 to
b78c75f
Compare
|
recheck |
Looks good now, thanks. Anything more to do? The linter did not complain about the empty lines. |
|
P.S.: And would it not be better to move the new config file s to the build folder? I can do that later in my PR, just like to know your opinion. |
if you have some time please do that, or add the files in the ignore list for production in the build tool |
24b99d5
into
richard67:5.4-dev-npm-update-2025-07-25
|
Thanks. Your help is much appreciated. Merged with a merge commit so you will be co-author of my CMS PR joomla#45784 . |
|
FWIW this setup is way less restrictive than the Airbnb but I guess the maintainers would have to decide if they want to invest on eslint configuration or move to something like biome or oxlint which are way faster and used more these days |
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed