Skip to content

5.4 dev npm update 2025 07 25#48

Merged
richard67 merged 1 commit intorichard67:5.4-dev-npm-update-2025-07-25from
dgrammatiko:5.4-dev-npm-update-2025-07-25
Jul 27, 2025
Merged

5.4 dev npm update 2025 07 25#48
richard67 merged 1 commit intorichard67:5.4-dev-npm-update-2025-07-25from
dgrammatiko:5.4-dev-npm-update-2025-07-25

Conversation

@dgrammatiko
Copy link
Copy Markdown

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 changed the base branch from 5.4-dev-npm-major-update-eslint-2025-07-26 to 5.4-dev-npm-update-2025-07-25 July 27, 2025 16:07
@richard67
Copy link
Copy Markdown
Owner

richard67 commented Jul 27, 2025

@dgrammatiko Could you check the diff? It seems your PR adds an empty line with a space everywhere where the // eslint-disable-next-line no-console is removed, so we have 90 changed files with such empty lines with spaces.

@richard67 richard67 changed the base branch from 5.4-dev-npm-update-2025-07-25 to 5.4-dev-npm-major-update-eslint-2025-07-26 July 27, 2025 16:33
@richard67 richard67 changed the base branch from 5.4-dev-npm-major-update-eslint-2025-07-26 to 5.4-dev-npm-update-2025-07-25 July 27, 2025 16:33
@dgrammatiko dgrammatiko force-pushed the 5.4-dev-npm-update-2025-07-25 branch from 4fe4157 to b78c75f Compare July 27, 2025 16:52
@dgrammatiko
Copy link
Copy Markdown
Author

recheck

@richard67
Copy link
Copy Markdown
Owner

recheck

Looks good now, thanks.

Anything more to do? The linter did not complain about the empty lines.

@richard67
Copy link
Copy Markdown
Owner

richard67 commented Jul 27, 2025

P.S.: And would it not be better to move the new config file s to the build folder?

I can do that later in my PR, just like to know your opinion.

@dgrammatiko
Copy link
Copy Markdown
Author

And would it not be better to move the new config file s to the build folder?

if you have some time please do that, or add the files in the ignore list for production in the build tool

@richard67 richard67 merged commit 24b99d5 into richard67:5.4-dev-npm-update-2025-07-25 Jul 27, 2025
30 checks passed
@richard67
Copy link
Copy Markdown
Owner

Thanks. Your help is much appreciated. Merged with a merge commit so you will be co-author of my CMS PR joomla#45784 .

@dgrammatiko
Copy link
Copy Markdown
Author

FWIW this setup is way less restrictive than the Airbnb but I guess the maintainers would have to decide if they want to invest on eslint configuration or move to something like biome or oxlint which are way faster and used more these days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants