Make immediate64 things mode cross (oxcaml#97)

ccasin · lpw25 · web-flow · commit d78ff6de461f · 2023-01-10T09:02:44.000-05:00
* Make immediate64 things mode cross

* Disable immediate64 test on 32bit architectures

Co-authored-by: Leo White &lt;leo@lpw25.net&gt;
diff --git a/testsuite/tests/typing-local/crossing.ml b/testsuite/tests/typing-local/crossing.ml
@@ -343,4 +343,4 @@ module M : sig type t [@@immediate] end
 type t2 = { x : int; } [@@unboxed]
 val f : local_ M.t -> M.t = <fun>
 val f : local_ t2 -> t2 = <fun>
-|}]  
+|}]
diff --git a/testsuite/tests/typing-local/crossing_64.ml b/testsuite/tests/typing-local/crossing_64.ml
@@ -0,0 +1,14 @@
+(* TEST
+ * arch64
+ ** expect *)
+
+(* Mode crossing works on immediate64 types *)
+module F (M : sig type t [@@immediate64] end) = struct
+  let f : local_ M.t -> _ = fun t -> t
+end
+
+[%%expect{|
+module F :
+  functor (M : sig type t [@@immediate64] end) ->
+    sig val f : local_ M.t -> M.t end
+|}]
diff --git a/typing/typecore.ml b/typing/typecore.ml
@@ -559,7 +559,7 @@ let mode_cross env (ty : type_expr) mode =
   if is_principal ty then begin
     match immediacy env ty with
     | Type_immediacy.Always -> Value_mode.newvar ()
-    | Type_immediacy.Always_on_64bits when !Clflags.native_code && Sys.word_size = 64 ->
+    | Type_immediacy.Always_on_64bits when Sys.word_size = 64 ->
         Value_mode.newvar ()  (* floating and relaxed *)
     | _ -> mode
   end
