Add sources and results for comparison#114
Conversation
a31a5be to
4de85dd
Compare
|
This is amazing to watch! Thank you for sharing along the way. I did have one question that I forgot to mention earlier. Is it recommended to take the middle of the day (noon) for these calculations? I experimented with various weather data sources that provide sun/moon data and couldn't really tell if there was an agreement on beginning vs middle of the day. For some sources, at least, it seems like they take the current time exactly to calculate the moon limitation, but some kept stable throughout the day. If there's a recommendation (perhaps from IMCCE?) to take noon, perhaps it's worth adding to the documentation/examples or even adding a setting to enable/disable normalizing any dates/times passed in? (I have no idea if any of this would be a good idea, just some food for thought considering that I had an open question around this...) |
|
@trevorturk I wouldn't say it is recommended, in my case I could have taken any fixed hour. The reason I selected noon instead of midnight, is that I noticed strange results with SunCalc providing data for the previous day. By using noon, I excluded this problem but I'm not sure why. Astronoby provides For Astronoby, prefer to keep it without recommendation because it is really a real-time computed value, technically it changes at each instant.
What do you think? |
|
Seems reasonable to me, thank you for your consideration and advice! |
7abda01 to
3be7b81
Compare
SunCalcCSV generation script
The following script helped generating
sun_calc.csvwith 474,337 combinations.IMCCE
CSV generation script
The following script helped generating imcce.csv with 474,337 combinations.
Fixed #113