Merged
Conversation
In some cases new iterations of rise-transit-set calculations are not more precise than the previous ones. Quite the opposite, it is apparently possible to loop indefinitely over some values without ever crossing the targeted precision. This introduces a limit of 5 iterations. Passed this limit, it is admitted that the program in its current form will not achieve a better precision. Fixes #109
billyyarosh
approved these changes
Nov 22, 2024
billyyarosh
left a comment
There was a problem hiding this comment.
This was going to be my proposal, but I didn't understand the purpose enough to propose this myself :)
|
Hey @rhannequin, can we get a bug fix release for this? ty |
Owner
Author
|
@billyyarosh Sure, that's my plan, however I just wanted to finish some accuracy investigations first. |
|
Yes, we can wait a couple of weeks. Thanks again. |
Owner
Author
|
@billyyarosh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases new iterations of rise-transit-set calculations are not more precise than the previous ones. Quite the opposite, it is apparently possible to loop indefinitely over some values without ever crossing the targeted precision.
This introduces a limit of 5 iterations. Passed this limit, it is admitted that the program in its current form will not achieve a better precision.
Fixes #109