Fix observation events times with local time dates#105
Merged
rhannequin merged 1 commit intomainfrom Nov 22, 2024
Merged
Conversation
Before, times from `Astronoby::Events::ObservationEvents` could produce wrong results when the location was far away from the Greenwich meridian. The reason was a bug when converting times (hour+minute+second) into `Time` objects. The date was correctly added by the time was in UTC. When converting back the UTC time to local time, the date could change. Now, the date is added depending on the time with concern of the user's UTC offset. The offset must be provided hen instantiating the `Astronoby::Observer` object using a new attribute: `#utc_offset`. ```rb utc_offset = "-05:00" time = Time.new(2015, 2, 5, 0, 0, 0, utc_offset) observer = Astronoby::Observer.new( latitude: Astronoby::Angle.from_degrees(38), longitude: Astronoby::Angle.from_degrees(-78), utc_offset: utc_offset ) sun = Astronoby::Sun.new(time: time) observation_events = sun.observation_events(observer: observer) observation_events.rising_time.getlocal(utc_offset) # => 2015-02-05 07:12:59 -0500 observation_events.transit_time.getlocal(utc_offset) # => 2015-02-05 12:25:59 -0500 observation_events.setting_time.getlocal(utc_offset) # => 2015-02-05 17:39:27 -0500 ```
Owner
Author
|
Here are some tests to compare results over several days, from different sources, for different locations. The point is to notice a significant difference that would make believe that the fix is actually a bug taking the data for the next or previous day.
The test don't show a significant error. This makes me think the fix is correct. |
|
🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, times from
Astronoby::Events::ObservationEventscould produce wrong results when the location was far away from the Greenwich meridian.The reason was a bug when converting times (hour+minute+second) into
Timeobjects. The date was correctly added by the time was in UTC. When converting back the UTC time to local time, the date could change.Now, the date is added depending on the time with concern of the user's UTC offset.
The offset must be provided hen instantiating the
Astronoby::Observerobject using a new attribute:#utc_offset.Fixes #97